Skip to content

Stop referencing GCS_CREDENTIALS #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

pquentin
Copy link
Member

We now use git to download recordings. Removed that from secrets already.

We now use git to download recordings.
@pquentin pquentin requested a review from a team as a code owner June 19, 2025 14:27
@pquentin pquentin added the skip-backport This pull request should not be backported label Jun 19, 2025
@pquentin pquentin merged commit e2eb519 into main Jun 19, 2025
9 of 10 checks passed
@pquentin pquentin deleted the remove-gcs-credential-reference branch June 19, 2025 18:09
@pquentin pquentin added backport 8.19 and removed skip-backport This pull request should not be backported labels Jun 24, 2025
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4624-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e2eb51961dee2ea2b133f6173cba6153c6e34cac
# Push it to GitHub
git push --set-upstream origin backport-4624-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4624-to-8.19.

pquentin added a commit that referenced this pull request Jun 24, 2025
We now use git to download recordings.

(cherry picked from commit e2eb519)
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jun 24, 2025
We now use git to download recordings.

(cherry picked from commit e2eb519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants